[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 28/49] target-i386: Remove gen_op_andl_T0_ffff
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 28/49] target-i386: Remove gen_op_andl_T0_ffff |
Date: |
Tue, 7 Jan 2014 13:00:18 -0800 |
Replace it with tcg_gen_ext16u_tl. In four places we can combine that
with a previous move into cpu_T[0], and in one place we can infer that
the zero-extension has already happened via the previous load.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 43 ++++++++++++++++++-------------------------
1 file changed, 18 insertions(+), 25 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index a0fba1b..502d129 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -252,11 +252,6 @@ static void gen_update_cc_op(DisasContext *s)
}
}
-static inline void gen_op_andl_T0_ffff(void)
-{
- tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xffff);
-}
-
static inline void gen_op_andl_T0_im(uint32_t val)
{
tcg_gen_andi_tl(cpu_T[0], cpu_T[0], val);
@@ -5007,8 +5002,9 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
break;
case 2: /* call Ev */
/* XXX: optimize if memory (no 'and' is necessary) */
- if (s->dflag == 0)
- gen_op_andl_T0_ffff();
+ if (s->dflag == 0) {
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_T[0]);
+ }
next_eip = s->pc - s->cs_base;
tcg_gen_movi_tl(cpu_T[1], next_eip);
gen_push_T1(s);
@@ -5036,8 +5032,9 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
gen_eob(s);
break;
case 4: /* jmp Ev */
- if (s->dflag == 0)
- gen_op_andl_T0_ffff();
+ if (s->dflag == 0) {
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_T[0]);
+ }
gen_op_jmp_T0();
gen_eob(s);
break;
@@ -6422,8 +6419,7 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
ot = MO_8;
else
ot = dflag ? MO_32 : MO_16;
- gen_op_mov_TN_reg(MO_16, 0, R_EDX);
- gen_op_andl_T0_ffff();
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[R_EDX]);
gen_check_io(s, ot, pc_start - s->cs_base,
SVM_IOIO_TYPE_MASK | svm_is_rep(prefixes) | 4);
if (prefixes & (PREFIX_REPZ | PREFIX_REPNZ)) {
@@ -6441,8 +6437,7 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
ot = MO_8;
else
ot = dflag ? MO_32 : MO_16;
- gen_op_mov_TN_reg(MO_16, 0, R_EDX);
- gen_op_andl_T0_ffff();
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[R_EDX]);
gen_check_io(s, ot, pc_start - s->cs_base,
svm_is_rep(prefixes) | 4);
if (prefixes & (PREFIX_REPZ | PREFIX_REPNZ)) {
@@ -6504,8 +6499,7 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
ot = MO_8;
else
ot = dflag ? MO_32 : MO_16;
- gen_op_mov_TN_reg(MO_16, 0, R_EDX);
- gen_op_andl_T0_ffff();
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[R_EDX]);
gen_check_io(s, ot, pc_start - s->cs_base,
SVM_IOIO_TYPE_MASK | svm_is_rep(prefixes));
if (use_icount)
@@ -6524,8 +6518,7 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
ot = MO_8;
else
ot = dflag ? MO_32 : MO_16;
- gen_op_mov_TN_reg(MO_16, 0, R_EDX);
- gen_op_andl_T0_ffff();
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[R_EDX]);
gen_check_io(s, ot, pc_start - s->cs_base,
svm_is_rep(prefixes));
gen_op_mov_TN_reg(ot, 1, R_EAX);
@@ -6550,16 +6543,18 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
if (CODE64(s) && s->dflag)
s->dflag = 2;
gen_stack_update(s, val + (2 << s->dflag));
- if (s->dflag == 0)
- gen_op_andl_T0_ffff();
+ if (s->dflag == 0) {
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_T[0]);
+ }
gen_op_jmp_T0();
gen_eob(s);
break;
case 0xc3: /* ret */
gen_pop_T0(s);
gen_pop_update(s);
- if (s->dflag == 0)
- gen_op_andl_T0_ffff();
+ if (s->dflag == 0) {
+ tcg_gen_ext16u_tl(cpu_T[0], cpu_T[0]);
+ }
gen_op_jmp_T0();
gen_eob(s);
break;
@@ -6575,15 +6570,13 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
} else {
gen_stack_A0(s);
/* pop offset */
- gen_op_ld_v(s, 1 + s->dflag, cpu_T[0], cpu_A0);
- if (s->dflag == 0)
- gen_op_andl_T0_ffff();
+ gen_op_ld_v(s, MO_16 + s->dflag, cpu_T[0], cpu_A0);
/* NOTE: keeping EIP updated is not a problem in case of
exception */
gen_op_jmp_T0();
/* pop selector */
gen_op_addl_A0_im(2 << s->dflag);
- gen_op_ld_v(s, 1 + s->dflag, cpu_T[0], cpu_A0);
+ gen_op_ld_v(s, MO_16 + s->dflag, cpu_T[0], cpu_A0);
gen_op_movl_seg_T0_vm(R_CS);
/* add stack offset */
gen_stack_update(s, val + (4 << s->dflag));
--
1.8.4.2
- [Qemu-devel] [PULL 20/49] target-i386: Tidy load + truncate, (continued)
- [Qemu-devel] [PULL 20/49] target-i386: Tidy load + truncate, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 21/49] target-i386: Tidy extend + store, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 22/49] target-i386: Tidy extend + move, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 23/49] target-i386: Remove gen_op_movl_T0_0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 25/49] target-i386: Remove gen_op_movl_T0_im*, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 27/49] target-i386: Remove gen_movtl_T*_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 26/49] target-i386: Remove gen_op_mov*_A0_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 28/49] target-i386: Remove gen_op_andl_T0_ffff,
Richard Henderson <=
- [Qemu-devel] [PULL 30/49] target-i386: Remove gen_op_movl_T0_T1, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 29/49] target-i386: Remove gen_op_andl_T0_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 31/49] target-i386: Remove gen_op_andl_A0_ffff, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 32/49] target-i386: Use TCGMemOp for 'ot' variables, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 33/49] target-i386: Change gen_op_add_reg_* size parameter to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 34/49] target-i386: Change gen_op_j*z_ecx size parameter to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 35/49] target-i386: Change aflag to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 36/49] target-i386: Change gen_op_mov_reg_A0 size parameter to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 38/49] target-i386: Tidy addr16 code in gen_lea_modrm, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 37/49] target-i386: Change dflag to TCGMemOp, Richard Henderson, 2014/01/07