[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/49] target-i386: Tidy movsl
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 16/49] target-i386: Tidy movsl |
Date: |
Tue, 7 Jan 2014 13:00:06 -0800 |
Always perform a sign-extending load. In the extremely unlikely
case that we've used an 0x66 prefix, the extension to 64-bits is
unnecessary but not wrong; the store will still examine only 16 bits.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index f3baa4d..0a414c4 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -7747,11 +7747,7 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
gen_op_mov_reg_T0(d_ot, reg);
} else {
gen_lea_modrm(env, s, modrm, ®_addr, &offset_addr);
- if (d_ot == MO_64) {
- gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0);
- } else {
- gen_op_ld_v(s, MO_32, cpu_T[0], cpu_A0);
- }
+ gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0);
gen_op_mov_reg_T0(d_ot, reg);
}
} else
--
1.8.4.2
- [Qemu-devel] [PULL 07/49] target-i386: Remove gen_op_ld_T0_A0, (continued)
- [Qemu-devel] [PULL 07/49] target-i386: Remove gen_op_ld_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 08/49] target-i386: Remove gen_op_ldu_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 09/49] target-i386: Remove gen_op_ld_T1_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 10/49] target-i386: Remove gen_op_lds_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 11/49] target-i386: Introduce gen_op_st_rm_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 06/49] target-i386: Replace OT_* constants with MO_* constants, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 12/49] target-i386: Remove gen_op_st_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 13/49] target-i386: Remove gen_op_st_T1_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 14/49] target-i386: Fix typo in gen_push_T1, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 15/49] target-i386: Tidy mov[sz][bw], Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 16/49] target-i386: Tidy movsl,
Richard Henderson <=
- [Qemu-devel] [PULL 17/49] target-i386: Remove unused arguments to gen_lea_modrm, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 18/49] target-i386: Use MO_BE for movbe, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 19/49] target-i386: Tidy gen_op_mov_TN_reg+tcg_gen_trunc_tl_i32, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 20/49] target-i386: Tidy load + truncate, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 21/49] target-i386: Tidy extend + store, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 22/49] target-i386: Tidy extend + move, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 23/49] target-i386: Remove gen_op_movl_T0_0, Richard Henderson, 2014/01/07