Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

[Markus Armbruster]

"Kirill A. Shutemov" <address@hidden> writes:

> Aneesh Kumar K.V wrote:
>> "Kirill A. Shutemov" <address@hidden> writes:
>> 
>> > Kirill A. Shutemov wrote:
>> >> Currently we have few issues with P9_STATS_GEN:
>> >> 
>> >>  - We don't try to read st_gen anything except files or directories, but
>> >>    still set P9_STATS_GEN bit in st_result_mask. It may mislead client:
>> >>    we present garbage as valid st_gen.
>> >> 
>> >>  - If we failed to get valid st_gen with ENOTTY, we ignore error, but
>> >>    still set P9_STATS_GEN bit in st_result_mask.
>> >> 
>> >>  - If we failed to get valid st_gen with any other errno, we fail
>> >>    getattr altogether. It's excessive: we block valid client use-cases,
>> >>    like chdir(2) to non-readable directory with execution bit set.
>> >> 
>> >> The patch fixes these issues and cleanup code a bit.
>> >> 
>> >> Signed-off-by: Kirill A. Shutemov <address@hidden>
>> >> Reviewed-by: Daniel P. Berrange <address@hidden>
>> >> Reviewed-by: Aneesh Kumar K.V <address@hidden>
>> >
>> > Ping?
>> >
>> 
>> I am hoping that this will go to upstream directly without me doing a
>> pull request ? Anthony, let me know if this need anything to be done
>> from my side
>
> So? Nobody cares?

Unlikely.  Your problem is that the "Anthony" route for patches has been
dug up, and approximately 95% of the traffic still trying to navigate it
fall into its holes and vanish without trace.  Recommend to try another
route.