[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float funct
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float functions take exact-width types |
Date: |
Mon, 06 Jan 2014 10:20:16 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/06/2014 05:11 AM, Peter Maydell wrote:
> Currently the int-to-float functions take types which are specified
> as "at least X bits wide", rather than "exactly X bits wide". This is
> confusing and unhelpful since it means that the callers have to include
> an explicit cast to [u]intXX_t to ensure the correct behaviour. Fix
> them all to take the exactly-X-bits-wide types instead.
>
> Note that this doesn't change behaviour at all since at the moment
> we happen to define the 'int32' and 'uint32' types as exactly 32 bits
> wide, and the 'int64' and 'uint64' types as exactly 64 bits wide.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> fpu/softfloat.c | 26 +++++++++++++-------------
> include/fpu/softfloat.h | 26 +++++++++++++-------------
> 2 files changed, 26 insertions(+), 26 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 13/24] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal, (continued)
- [Qemu-devel] [PATCH v2 13/24] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 21/24] target-arm: A64: Add "Floating-point<->fixed-point" instructions, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 19/24] target-arm: Ignore most exceptions from scalbn when doing fixpoint conversion, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 24/24] target-arm: A64: Add support for FCVT between half, single and double, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 14/24] softfloat: Add float16 <=> float64 conversion functions, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float functions take exact-width types, Peter Maydell, 2014/01/06
- Re: [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float functions take exact-width types,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 01/24] softfloat: Fix exception flag handling for float32_to_float16(), Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 02/24] softfloat: Add float to 16bit integer conversions., Peter Maydell, 2014/01/06