[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 07/10] qapi: convert BlockdevOptions to use e
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH V5 07/10] qapi: convert BlockdevOptions to use enum discriminator |
Date: |
Mon, 06 Jan 2014 10:01:02 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
δΊ 2013/12/20 13:23, Wenchao Xia ει:
> After this patch, hidden enum type BlockdevOptionsKind will not
> be generated, and other API can use enum BlockdevDriver.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> qapi-schema.json | 14 +++++++++++++-
> 1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index c3c939c..9b51dcc 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4046,6 +4046,18 @@
> '*no-flush': 'bool' } }
>
> ##
> +# @BlockdevDriver
> +#
> +# Drivers that are supported in block device operations.
> +#
> +# Since: 2.0
> +##
> +{ 'enum': 'BlockdevDriver',
> + 'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'bochs',
> + 'cloop', 'cow', 'dmg', 'parallels', 'qcow', 'qcow2', 'qed',
> 'raw',
> + 'vdi', 'vhdx', 'vmdk', 'vpc' ] }
> +
> +##
> # @BlockdevOptionsBase
> #
> # Options that are available for all block devices, independent of the block
> @@ -4068,7 +4080,7 @@
> # Since: 1.7
> ##
> { 'type': 'BlockdevOptionsBase',
> - 'data': { 'driver': 'str',
> + 'data': { 'driver': 'BlockdevDriver',
> '*id': 'str',
> '*discard': 'BlockdevDiscardOptions',
> '*cache': 'BlockdevCacheOptions',
>
Hi Kevin,
Could u take a look at this patch?
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH V5 07/10] qapi: convert BlockdevOptions to use enum discriminator,
Wenchao Xia <=