Re: [Qemu-devel] [PATCH 04/10] target-arm: A64: Add "Floating-point data-processing (2 source)" insns

[Richard Henderson]

On 12/28/2013 01:49 PM, Peter Maydell wrote:
> From: Alexander Graf <address@hidden>
> 
> This patch adds emulation for the "Floating-point data-processing (2 source)"
> group of instructions.
> 
> Signed-off-by: Alexander Graf <address@hidden>
> [WN: Commit message tweak, merge single and double precision patches. Rebase
>  and update to new infrastructure. Incorporate FMIN/FMAX support patch by
>  Michael Matz.]
> Signed-off-by: Will Newton <address@hidden>
> [PMM:
>  * added convenience accessors for FP s and d regs
>  * pulled the field decode and opcode validity check up a level]
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target-arm/translate-a64.c | 182 
> ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 181 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <address@hidden>

... and I take back what I said earlier about fp_reg_offset.  While that
specific fp store case could stand to be cleaned up to just use one 64-bit
load, the single-precision case is compelling.


r~