Re: [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality

[Michael S. Tsirkin]

On Thu, Dec 26, 2013 at 02:19:48PM +0200, Marcel Apfelbaum wrote:
> Acpi unit-test will fail every time the acpi tables change.
> 
> The series adds a script that rebuilds the expected aml files, so the test
> will pass. It also validates the modifications.
> 
> The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML
> environment variable is set.

OK I had to fix some trailing whitespace, otherwise
looks good.
I applied it all, pls check the pci branch.

> v1 -> v2:
> Addressed Michael S. Tsirkin's comments:
>  - added TEST_ prefix to the environment variable
>  - some rephrases
> 
> Marcel Apfelbaum (2):
>   acpi unit-test: added script to rebuild the expected aml files
>   acpi unit-test: hook to rebuild expected aml files
> 
>  tests/acpi-test-data/rebuild-expected-aml.sh | 36 
> ++++++++++++++++++++++++++++
>  tests/acpi-test.c                            | 30 +++++++++++++++++++----
>  2 files changed, 61 insertions(+), 5 deletions(-)
>  create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh
> 
> -- 
> 1.8.3.1