qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/2] ui/cocoa: Fix non-blanked display window if gue


From: Peter Maydell
Subject: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix non-blanked display window if guest never uses it
Date: Tue, 24 Dec 2013 02:51:45 +0000

This patch series fixes a couple of bugs in drawing the display
which are only really visible if you run guests with no graphics
device or which never get round to using the graphics device.

The first is a fix for a bug in the order in which we handled
surface switching which meant that if the surface was resized
from 640x480 to 1024x768 we would draw the new data at the old
size and then resize the window (which on MacOSX doesn't
provoke a redraw). So we wouldn't update the display properly
until the next time the guest updated the framebuffer.

The second patch just says "if we're asked to draw and there's
nothing from the guest yet, draw black"; this means that if
the guest has no graphics device we have a black window rather
than a white one, which is more in line with behaviour of
other UI frontends.

NB: the changes to switchSurface were to some extent made
by trial and error and googling of documentation, so ideally
they could use code review from somebody who understands
Cocoa better than I do.

Peter Maydell (2):
  ui/cocoa: Redraw at correct size when switching surface
  ui/cocoa: Draw black rectangle if we have no data yet

 ui/cocoa.m | 31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)

-- 
1.7.11.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]