[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditio
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditional compare insns |
Date: |
Fri, 20 Dec 2013 16:19:43 +0000 |
On 19 December 2013 21:04, Richard Henderson <address@hidden> wrote:
> On 12/17/2013 07:12 AM, Peter Maydell wrote:
>> +static void disas_cc(DisasContext *s, uint32_t insn)
>> {
>> + unsigned int sf, op, y, cond, rn, nzcv, is_imm;
>> + int label_continue;
>> + TCGv_i64 tcg_tmp, tcg_y, tcg_rn;
>
> Don't you get a may be used uninitialized warning for label_continue?
I know some versions of gcc tend to be bad at that,
but at least for mine (gcc-4.6.3) it doesn't warn about this
even with optimization enabled.
Is it worth pulling the assignment
label_continue = gen_new_label();
out of the if() to protect against possible less smart compilers?
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 11/21] target-arm: Update generic cpreg code for AArch64, (continued)
Re: [Qemu-devel] [PATCH 11/21] target-arm: Update generic cpreg code for AArch64, Peter Crosthwaite, 2013/12/19
[Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditional compare insns, Peter Maydell, 2013/12/17
Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditional compare insns,
Peter Maydell <=
Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditional compare insns, Richard Henderson, 2013/12/20
[Qemu-devel] [PATCH 01/21] target-arm: A64: add support for ld/st pair, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 05/21] target-arm: A64: add support for add, addi, sub, subi, Peter Maydell, 2013/12/17