qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmps


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmpstr()
Date: Thu, 19 Dec 2013 16:38:07 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Dec 18, 2013 at 07:31:48PM +0100, Andreas Färber wrote:
> Am 18.12.2013 17:34, schrieb Stefan Hajnoczi:
> > Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3).
> 
> I vaguely remember that some such handy function was introduced only
> after the minimum GLib version we require. Did you check on that?
> But IIRC we already have higher requirements for qtest that for the
> non-check code so it might not really matter...

Yes, before using it I did git grep g_assert_cmpstr.  It's already used
in many other test cases like tests/check-qjson.c.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]