[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device non
From: |
armbru |
Subject: |
[Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant |
Date: |
Thu, 19 Dec 2013 15:30:13 +0100 |
From: Markus Armbruster <address@hidden>
Once upon a time, the error message was:
qemu: -device nonexistant: "Device "nonexistant" not found. Try -device
'?' for a list.
But progress marches on, and conversion to QError (commit 0204276)
changed it into:
Invalid parameter 'driver'
Try with argument '?' for a list.
Progress didn't stop there, of course. After a couple of iterations,
we arrived at the current message (commit 6acbe4c):
qemu: -device nonexistant: Parameter 'driver' expects device type
Mission accomplished: this is complete mush.
We've since abandoned our quest for "rich" error objects, fortunately
before it turned all error messages into mush. Time to undo the
damage to this one. Make it:
qemu: -device nonexistant: nonexistant is not a valid device model name
Signed-off-by: Markus Armbruster <address@hidden>
---
qdev-monitor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index dc37a43..6251107 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -478,7 +478,8 @@ DeviceState *qdev_device_add(QemuOpts *opts)
}
if (!oc) {
- qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "device type");
+ qerror_report(ERROR_CLASS_GENERIC_ERROR,
+ "'%s' is not a valid device model name", driver);
return NULL;
}
--
1.8.1.4
- [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant,
armbru <=