Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

[Andreas Färber]

I had a brief look at this series. Dropping redundant fields certainly
sounds good and after the lengthy QOM'ifications of IDE devices we seem
to no longer break any devices, but whether to check for device or
BlockDriverState sounds more like a block topic to me...

Regards,
Andreas

Am 18.12.2013 15:54, schrieb Markus Armbruster:
> Ping?
> 
> address@hidden writes:
> 
>> From: Markus Armbruster <address@hidden>
>>
>> Obvious cleanups possible since we no longer have the special case of
>> a non-qdevified controller.
>>
>> v2:
>> * Dropped PATCH 1/10 ide: Break all non-qdevified controllers
>>   Andreas qdevified them since; thanks!
>> * Series renamed from "Drop code for non-qdevified IDE, and clean up"
>> * Trivially rebased
>>
>> Markus Armbruster (9):
>>   ide: Move IDEDevice pointer from IDEBus to IDEState
>>   ide: Use IDEState member dev for "device connected" test
>>   ide: Don't block-align IDEState member smart_selftest_data
>>   ide: Drop redundant IDEState member bs
>>   ide: Drop redundant IDEState geometry members
>>   ide: Drop redundant IDEState member version
>>   ide: Drop redundant IDEState member drive_serial_str
>>   ide: Drop redundant IDEState member model
>>   ide: Drop redundant IDEState member wwn
>>
>>  hw/ide/ahci.c       |  19 +++--
>>  hw/ide/atapi.c      |  39 +++++----
>>  hw/ide/core.c       | 235 
>> +++++++++++++++++++++++-----------------------------
>>  hw/ide/internal.h   |  15 +---
>>  hw/ide/macio.c      |  26 +++---
>>  hw/ide/microdrive.c |   2 +-
>>  hw/ide/piix.c       |   4 -
>>  hw/ide/qdev.c       |  50 ++++++-----
>>  8 files changed, 181 insertions(+), 209 deletions(-)


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg