[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition c
From: |
Jens Freimann |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code |
Date: |
Tue, 17 Dec 2013 16:50:49 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Dec 17, 2013 at 03:01:43PM +0100, Alexander Graf wrote:
>
> On 17.12.2013, at 14:22, Jens Freimann <address@hidden> wrote:
>
> > From: Thomas Huth <address@hidden>
> >
> > I missed to set the CC in the CHSC instruction when I refactored
> > the CC setting in the IO instructions with the following commit:
> > 5d9bf1c07c1369ab3506fc82cc65a10f4415d867
> > s390/ioinst: Moved the CC setting to the IO instruction handlers
> > This patch now restores the correct behaviour of CHSC by setting the
> > condition code 0 at the end of the instruction.
> >
> > Signed-off-by: Thomas Huth <address@hidden>
> > Reviewed-by: Cornelia Huck <address@hidden>
> > Signed-off-by: Jens Freimann <address@hidden>
>
> I suppose this patch should be CC'ed to stable?
Good point, I'll send it again with stable on CC.
Same thing for Patch 1/8.
Thanks!
regards
Jens
>
> Alex
>
> > ---
> > target-s390x/ioinst.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c
> > index 8d6363d..b8a6486 100644
> > --- a/target-s390x/ioinst.c
> > +++ b/target-s390x/ioinst.c
> > @@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb)
> > break;
> > }
> >
> > + setcc(cpu, 0); /* Command execution complete */
> > out:
> > s390_cpu_physical_memory_unmap(env, req, map_size, 1);
> > }
> > --
> > 1.8.3.4
> >
>
>
- [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 1/8] s390x/kvm: Fix diagnose handling., Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 4/8] s390x/kvm: Fix coding style in handle_sigp(), Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 2/8] s390x/kvm: Removed duplicated SIGP defines, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 3/8] s390x/kvm: Removed s390_store_status stub, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 6/8] s390x/kvm: Simplified the calculation of the SIGP order code, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START, Jens Freimann, 2013/12/17
- [Qemu-devel] [PATCH 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders, Jens Freimann, 2013/12/17
- Re: [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups, Alexander Graf, 2013/12/18