[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, a
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation |
Date: |
Tue, 17 Dec 2013 06:56:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/17/2013 03:33 AM, Jeff Cody wrote:
> If there is a dirty log file to be replayed in a VHDX image, it is
> replayed in .vhdx_open(). However, if the file is opened read-only,
> then a somewhat cryptic error message results.
>
> This adds a more helpful error message for the user. If an image file
> contains a log to be replayed, and is opened read-only, the user is
> instructed to run 'qemu-img check -r all' on the image file.
>
> Running qemu-img check -r all will cause the image file to be opened
> r/w, which will replay the log file. If a log file replay is detected,
> this is flagged, and bdrv_check will increase the corruptions_fixed
> count for the image.
> + error_setg_errno(errp, EPERM,
> + "VHDX image file '%s' opened read-only, but "
> + "contains a log that needs replayed. To replay
> "
s/replayed/replaying/
> + "the log, execute:\n qemu-img check -r all
> '%s'",
> + bs->filename, bs->filename);
> + goto exit;
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature