[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 20/22] exec: Make cpu_memory_rw_debug use the
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v1 20/22] exec: Make cpu_memory_rw_debug use the CPUs AS |
Date: |
Tue, 17 Dec 2013 10:52:35 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 16, 2013 at 01:48:10PM +0100, Andreas Färber wrote:
> Am 16.12.2013 09:06, schrieb address@hidden:
> > From: "Edgar E. Iglesias" <address@hidden>
> >
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
> > exec.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/exec.c b/exec.c
> > index 686f0d1..e672824 100644
> > --- a/exec.c
> > +++ b/exec.c
> > @@ -2669,6 +2669,7 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong
> > addr,
> > int l;
> > hwaddr phys_addr;
> > target_ulong page;
> > + CPUArchState *env = cpu->env_ptr;
> >
> > while (len > 0) {
> > page = addr & TARGET_PAGE_MASK;
> > @@ -2681,10 +2682,9 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong
> > addr,
> > l = len;
> > phys_addr += (addr & ~TARGET_PAGE_MASK);
> > if (is_write)
> > - cpu_physical_memory_write_rom(&address_space_memory,
> > - phys_addr, buf, l);
> > + cpu_physical_memory_write_rom(env->as, phys_addr, buf, l);
> > else
> > - cpu_physical_memory_rw(phys_addr, buf, l, is_write);
> > + address_space_rw(env->as, phys_addr, buf, l, 0);
>
> Add braces for if and else while at it? :)
Fixed, thanks.
- [Qemu-devel] [PATCH v1 12/22] exec: Make ldq/ldub_*_phys input an AddressSpace, (continued)
- [Qemu-devel] [PATCH v1 12/22] exec: Make ldq/ldub_*_phys input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 13/22] exec: Make lduw_*_phys input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 14/22] exec: Make stq_*_phys input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 15/22] exec: Make stl_*_phys input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 16/22] exec: Make stl_phys_notdirty input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 17/22] exec: Make stw_*_phys input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 18/22] exec: Make stb_phys input an AddressSpace, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 19/22] exec: Make cpu_physical_memory_write_rom input an AS, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 20/22] exec: Make cpu_memory_rw_debug use the CPUs AS, edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 21/22] petalogix-ml605: Create the CPU with object_new(), edgar . iglesias, 2013/12/16
- [Qemu-devel] [PATCH v1 22/22] petalogix-ml605: Make the LMB visible only to the CPU, edgar . iglesias, 2013/12/16
- Re: [Qemu-devel] [PATCH v1 22/22] petalogix-ml605: Make the LMB visible only to the CPU, Edgar E. Iglesias, 2013/12/16