[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttri
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes |
Date: |
Mon, 16 Dec 2013 15:27:17 +0100 |
Hi,
> I thought that for lines that are just a logical or of constants
> it would be ok to go over 80 columns, since the alternatives
>
> (shortening the names of constants or breaking the line)
>
> are a little less readable.
I don't find the broken lines unreadable, especially if
you align the stuff nicely like you did ...
> ... and broke the two lines
> that were still longer than 80 columns,
... here.
But if you prefer it this way with the shorter constants, no problem,
I'll happily take it as-is.
cheers,
Gerd