Re: [Qemu-devel] [PATCH v3 5/7] Add vhost-user calls implementation

[Luke Gorrie]

Cool stuff :-)

some thoughts:

On 13 December 2013 12:14, Antonios Motakis
<address@hidden> wrote:
>  static int vhost_user_recv(int fd, VhostUserMsg *msg)
>  {
>      ssize_t r = read(fd, msg, sizeof(VhostUserMsg));

Is it worth considering a "timeout and reconnect" check here? I mean
so that if the vhost server does not respond for any reason the guess
will see link down instead of freezing the hypervisor (?).

> +    case VHOST_SET_VRING_ADDR:
> +        memcpy(&msg.addr, arg, sizeof(struct vhost_vring_addr));
> +        break;

I think these vring addresses need to be remapped from qemu address
space to guest-physical address space.