[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051 |
Date: |
Fri, 13 Dec 2013 13:21:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/13/2013 10:10 AM, Max Reitz wrote:
> Allowing nested file formats now results in e.g. qcow2 BlockDriverStates
> never being directly passed to bdrv_open_common() from bdrv_file_open(),
> but instead being handed through bdrv_open(). This changes the error
> message when trying to give a filename to qcow2, i.e. trying to use it
> as a driver for the protocol level.
Shouldn't this be squashed with the patch that changed the error
message, so that a bisection doesn't hit the broken test? Besides,
touching the testsuite at the same time as the rest of the code base
shows that you are aware of the changes caused by your code.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051, Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 14/22] blockdev: Move "file" to legacy_opts, Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration, Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 16/22] blkdebug: Make filename optional, Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 18/22] blkverify: Don't require protocol filename, Max Reitz, 2013/12/13