Re: [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility

[Paolo Bonzini]

Il 29/11/2013 18:12, Laszlo Ersek ha scritto:
> v3 [Markus]:
> - FW_SIZE -> BLOB_SIZE
> - create_firmware() -> create_blob_file()
> - detach create_blob_file() comment block from firmware & temporariness
> - same in filename and error messages there
> - char unsigned -> uint8_t

Great idea. :)

> 
> Laszlo Ersek (4):
>   i440fx-test: qtest_start() should be paired with qtest_end()
>   i440fx-test: give each GTest case its own qtest
>   i440fx-test: generate temporary firmware blob
>   i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash
> 
>  tests/i440fx-test.c | 167 
> ++++++++++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 150 insertions(+), 17 deletions(-)
> 

Markus, can you give your Reviewed-by?

Paolo