Re: [Qemu-devel] [PATCH v2] libcacard: Fix compilation for older versions of glib (bug #1258168)

[Stefan Weil]

Am 08.12.2013 10:13, schrieb Alon Levy:
> On 12/05/2013 08:41 PM, Stefan Weil wrote:
>> See https://bugs.launchpad.net/bugs/1258168
>>
>> libcacard/vscclient.c: In function 'do_socket_read':
>> libcacard/vscclient.c:410: warning: implicit declaration of function 
>> 'g_warn_if_reached'
>> libcacard/vscclient.c:410: warning: nested extern declaration of 
>> 'g_warn_if_reached'
>> libcacard/vscclient.c: In function 'main':
>> libcacard/vscclient.c:763: warning: implicit declaration of function 
>> 'g_byte_array_unref'
>> libcacard/vscclient.c:763: warning: nested extern declaration of 
>> 'g_byte_array_unref'
>> ...
>> libcacard/vscclient.o: In function `do_socket_read':
>> libcacard/vscclient.c:410: undefined reference to `g_warn_if_reached'
>> libcacard/vscclient.o: In function `main':
>> libcacard/vscclient.c:763: undefined reference to `g_byte_array_unref'
>>
>> g_warn_if_reached was added in glib 2.16, and g_byte_array_unref is
>> supported since glib 2.22. QEMU requires glib 2.12, so both names must
>> not be used.
>>
>> Instead of showing a warning for code which should not be reached, QEMU
>> better stops running, so g_warn_if_reached is not useful for QEMU.
> Just note that this fix is in vscclient, so this code is not part of
> qemu executable. If you are using QEMU (all caps) as the whole project,
> the commit message is ok, but it should clarify this is about the
> separate vscclient executable.
>
> Other then that ACK, I can send a pull request with the commit message
> fixed as I suggested.

Thanks for this hint. Please fix the commit message as you suggested.

Regards,
Stefan