Re: [Qemu-devel] [PATCH for-1.7] target-mips: fix 64-bit FPU config for user-mode emulation

[Petar Jovanovic]

ping
http://patchwork.ozlabs.org/patch/295442/


________________________________________
From: Andreas Färber address@hidden
Sent: Friday, November 29, 2013 6:04 PM
To: Petar Jovanovic; address@hidden
Cc: Petar Jovanovic; address@hidden; qemu-stable
Subject: Re: [Qemu-devel] [PATCH for 1.7] target-mips: fix 64-bit FPU config 
for user-mode emulation

Am 29.11.2013 17:27, schrieb Petar Jovanovic:
> From: Petar Jovanovic <address@hidden>
>
> FR bit should be initialized to 1 for MIPS64, under condition that this
> bit is writable and that CPU has an FPU unit. It should be initialized to
> zero for MIPS32.
> This fixes different MIPS32 issues with FPU instructions whose behaviour
> defaulted to 64-bit FPU mode.
>
> Signed-off-by: Petar Jovanovic <address@hidden>
> ---
>
> A few issues have been raised over the time because this part of the code
> did the wrong thing for MIPS32. This change is sufficient to fix the
> reported issues, such as https://bugs.launchpad.net/qemu/+bug/1233225.
> This change does not attempt to cover -mfp64 mode that should be
> subject of different yet related change.
> We should have this in v1.7 since it is a regression for frequently used
> QEMU MIPS32 usermode.

v1.7.0 has already been released, so it's too late for "for 1.7".
Also please prefer "for-x.y" syntax next time, since the space is
treated as token delimiter and "for" is not a meaningful token. ;)
http://patchwork.ozlabs.org/patch/295442/

What you need instead to get it into the 1.7 stable release is
Cc: address@hidden
in the commit message, to have it backported for v1.7.1.

Regards,
Andreas

--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg