[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset |
Date: |
Thu, 05 Dec 2013 17:38:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 05/12/2013 17:17, Marcelo Tosatti ha scritto:
>> > I agree it is a bit ugly, but in my testing QEMU seemed to loop over all
>> > the VCPUS fast enough for the kernel side kvm_write_tsc() to do a
>> > reasonable job of matching the offsets (the Linux guest did not mark
>> > the TSC unstable due to the TSCs being unsynchronized). Am I missing
>> > something?
> Right, modern kernels (see kvm_write_tsc) perform synchronization, so in
> theory the "KVM is yet unable to synchronize ..." code is not necessary
> anymore.
>
> I vote for dropping the thing entirely.
If it can be dropped entirely, I certainly have no problem with starting
with a simple patch first.
Paolo
- Re: [Qemu-devel] [PATCH] kvm: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/05
- [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Paolo Bonzini, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vazquez Cao, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Paolo Bonzini, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vazquez Cao, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Paolo Bonzini, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Marcelo Tosatti, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Marcelo Tosatti, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Marcelo Tosatti, 2013/12/05
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/06
- [Qemu-devel] [PATCH 1//2 v3] target-i386: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/06
- [Qemu-devel] [PATCH 2/2] target-i386: do not special case TSC writeback, Fernando Luis Vázquez Cao, 2013/12/06
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Paolo Bonzini, 2013/12/06
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/06
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Paolo Bonzini, 2013/12/06
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vazquez Cao, 2013/12/06
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Marcelo Tosatti, 2013/12/06
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/09
- Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset, Fernando Luis Vázquez Cao, 2013/12/11