[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v0 2/3] gluster: Implement .bdrv_co_write_ze
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v0 2/3] gluster: Implement .bdrv_co_write_zeroes for gluster |
|
Date: |
Thu, 5 Dec 2013 16:15:02 +0530 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Dec 04, 2013 at 02:16:28PM -0500, Jeff Cody wrote:
> On Fri, Nov 22, 2013 at 12:46:17PM +0530, Bharata B Rao wrote:
> > +
> > + ret = glfs_zerofill_async(s->fd, offset, size, &gluster_finish_aiocb,
> > acb);
> > + if (ret < 0) {
>
> I believe glfs_zerofill_async returns -1 on failure, and sets errno.
> In that case, we should set ret = -errno here.
This needs to be done for other routines too. Will address this and the
other comment you have given in 2/3 thread. Thanks.
Regards,
Bharata.