Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address

[Peter Maydell]

On 2 December 2013 07:10, Peter Crosthwaite
<address@hidden> wrote:
> This has no real hardware analog. Leave the error message in is as
> it is almost certainly a guest error, but fallthrough to the expected
> behaviour.

Maybe we should qemu_log_mask(LOG_GUEST_ERROR, ...)  then?

> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
>  hw/net/cadence_gem.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index b84ee60..3f30caf 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -694,7 +694,6 @@ static ssize_t gem_receive(NetClientState *nc, const 
> uint8_t *buf, size_t size)
>          if (rx_desc_get_buffer(desc) == 0) {
>              DB_PRINT("Invalid RX buffer (NULL) for descriptor 0x%x\n",
>                       (unsigned)packet_desc_addr);
> -            break;
>          }
>
>          /* Copy packet data to emulated DMA buffer */
> --
> 1.8.4.4
>

-- PMM