[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/13] nbd: don't change socket block during neg
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 09/13] nbd: don't change socket block during negotiate |
Date: |
Sun, 1 Dec 2013 15:56:51 -0500 (EST) |
----- Original Message -----
> Il 30/11/2013 16:49, Marc-André Lureau ha scritto:
> > So you suggest this block/unblock: (I haven't reviewed all callers of
> > unix_connect_opts(), I am not sure that's what you meant) Other option
> > would be to move the nonblock to unix_socket_outgoing.
> >
> > diff --git a/block/nbd-client.c b/block/nbd-client.c
> > index 1abfc6a..693110d 100644
> > --- a/block/nbd-client.c
> > +++ b/block/nbd-client.c
> > @@ -348,6 +348,7 @@ int nbd_client_session_init(NbdClientSession *client,
> > int ret;
> >
> > /* NBD handshake */
> > + qemu_set_block(sock);
> > ret = nbd_receive_negotiate(sock, client->export_name,
> > &client->nbdflags, &client->size,
> > &client->blocksize);
>
> Also
>
> qemu_set_nonblock(sock);
>
> here,
It's already a few lines below.
> and remove it from nbd_receive_negotiate.
> I checked again and you need not touch unix_connect_opts, nor
> nbd_client_thread.
Ok, I'll remove those.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 09/13] nbd: don't change socket block during negotiate,
Marc-André Lureau <=