[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob |
Date: |
Fri, 29 Nov 2013 17:26:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 29/11/2013 16:07, Laszlo Ersek ha scritto:
> I think that the way I did it here matches this situation well. After
> the g_file_open_tmp() call succeeds, we must close fd in any case
> (independently of whether as a whole the function succeeds or not).
> Optionally, we must also unlink the file, in the same logical spot where
> the close() is. (Because g_file_open() creates three resources at once,
> a node in the filesystem, a file descriptor in the process, and a
> dynamically allocated string.)
I agree that the way you wrote it makes sense if you do not use goto.
Paolo
[Qemu-devel] [PATCH v2 2/4] i440fx-test: give each GTest case its own qtest, Laszlo Ersek, 2013/11/28
Re: [Qemu-devel] [PATCH v2 0/4] i440fx-test: check firmware visibility, Laszlo Ersek, 2013/11/28