[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev-monitor: device_add crashes on non-device
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] qdev-monitor: device_add crashes on non-device driver name, fix |
Date: |
Thu, 28 Nov 2013 17:19:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 28.11.2013 17:02, schrieb address@hidden:
>> From: Markus Armbruster <address@hidden>
>>
>> Watch this:
>>
>> $ upstream-qemu -nodefaults -S -display none -monitor stdio
>> QEMU 1.7.50 monitor - type 'help' for more information
>> (qemu) device_add rng-egd
>> /work/armbru/qemu/qdev-monitor.c:491:qdev_device_add: Object
>> 0x2089b00 is not an instance of type device
>> Aborted (core dumped)
>>
>> Crashes because "rng-egd" exists, but isn't a subtype of TYPE_DEVICE.
>> Broken in commit 18b6dad.
>
> Thanks for catching this!
>
>>
>> Cc: address@hidden
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> qdev-monitor.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qdev-monitor.c b/qdev-monitor.c
>> index dc37a43..90a0cea 100644
>> --- a/qdev-monitor.c
>> +++ b/qdev-monitor.c
>> @@ -477,7 +477,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
>> }
>> }
>>
>> - if (!oc) {
>> + if (!object_class_dynamic_cast(oc, TYPE_DEVICE)) {
>
> Are you sure we don't need !oc || !object_class_dynamic_cast(oc, ...)?
Yes. First thing object_class_dynamic_cast() does is
if (!class) {
return NULL;
}
Makes sense to me.
[...]