[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC qom-cpu v4 05/10] qmp: add 'cpu-del' command suppo
From: |
Chen Fan |
Subject: |
Re: [Qemu-devel] [RFC qom-cpu v4 05/10] qmp: add 'cpu-del' command support |
Date: |
Thu, 28 Nov 2013 09:14:03 +0800 |
On Wed, 2013-11-27 at 07:00 -0700, Eric Blake wrote:
> On 10/09/2013 03:43 AM, Chen Fan wrote:
> > Signed-off-by: Chen Fan <address@hidden>
> > ---
> > hw/i386/pc.c | 6 ++++++
> > hw/i386/pc_piix.c | 3 ++-
> > include/hw/boards.h | 2 ++
> > include/hw/i386/pc.h | 1 +
> > qapi-schema.json | 12 ++++++++++++
> > qmp-commands.hx | 23 +++++++++++++++++++++++
> > qmp.c | 9 +++++++++
> > 7 files changed, 55 insertions(+), 1 deletion(-)
>
> > +++ b/qapi-schema.json
> > @@ -1479,6 +1479,18 @@
> > ##
> > { 'command': 'cpu-add', 'data': {'id': 'int'} }
> >
> > +# @cpu-del
> > +
> > +# Deletes CPU with specified ID
> > +#
> > +# @id: ID of CPU to be deleted, valid values [0..max_cpus)
> > +#
> > +# Returns: Nothing on success
> > +#
> > +# Since 1.7
>
> Since this mail is still titled RFC, there's no way it will make it into
> 1.7. Are you shooting for 1.8?
>
Hi, this patchseries had not been commented yet, maybe I should send it
again after Rebase without RFC for 1.8.
Thanks,
Chen