Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

[Peter Maydell]

On 27 November 2013 09:42, Andreas Färber <address@hidden> wrote:
> If we turn it into a dynamic property, we could register it conditional
> to ARM_FEATURE_CBAR.

Unfortunately feature flags only get set at realize (in the
per-cpu init function), so we don't know at the point where
we're registering properties whether to have this one or not.

The other option would be to define an a9 cpu class init fn to
put the property in.

> The overall idea of the series makes sense to me. I would caution to
> think about the naming scheme though - we might want to have a "cbar"
> property to access the current value whereas we'll likely end up having
> several reset values to configure over time.

Mmm, maybe. The approach I think we've taken in some other
places (eg the cache controller) is to have the property names
match the silicon's config or control signal names (which in
this case would be PERIPHBASE), but they are not always
consistent from CPU to CPU, so that might be more confusing
than helpful. I don't think I have a strong opinion here, so I'd
be happy with any vaguely consistent-looking plan.

-- PMM