[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb) |
Date: |
Tue, 26 Nov 2013 10:51:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 26/11/2013 09:56, Peter Lieven ha scritto:
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> qemu-img.c | 4 ++--
> qemu-img.texi | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index cc7540f..6f1179b 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -101,7 +101,7 @@ static void help(void)
> " '-p' show progress of command (only certain commands)\n"
> " '-pp' show progress of command in sectors (only convert
> command)\n"
> " '-q' use Quiet mode - do not print any output (except
> errors)\n"
> - " '-S' indicates the consecutive number of bytes (defaults to
> 4k) that must\n"
> + " '-S' indicates the consecutive number of bytes (defaults to
> 64k) that must\n"
> " contain only zeros for qemu-img to create a sparse image
> during\n"
> " conversion. If the number of bytes is 0, the source will
> not be scanned for\n"
> " unallocated or zero sectors, and the destination image
> will always be\n"
> @@ -1158,7 +1158,7 @@ static int img_convert(int argc, char **argv)
> QEMUOptionParameter *out_baseimg_param;
> char *options = NULL;
> const char *snapshot_name = NULL;
> - int min_sparse = 8; /* Need at least 4k of zeros for sparse detection */
> + int min_sparse = 128; /* Need at least 64k of zeros for sparse detection
> */
> bool quiet = false;
> Error *local_err = NULL;
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index cb4a3eb..c0e86ab 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -195,7 +195,7 @@ Image conversion is also useful to get smaller image when
> using a
> growable format such as @code{qcow} or @code{cow}: the empty sectors
> are detected and suppressed from the destination image.
>
> address@hidden indicates the consecutive number of bytes (defaults to 4k)
> address@hidden indicates the consecutive number of bytes (defaults to 64k)
> that must contain only zeros for qemu-img to create a sparse image during
> conversion. If @var{sparse_size} is 0, the source will not be scanned for
> unallocated or zero sectors, and the destination image will always be
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCHv2 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert, (continued)
- [Qemu-devel] [PATCHv2 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 3/9] block/iscsi: set bdi->cluster_size, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 4/9] block: add opt_transfer_length to BlockLimits, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb), Peter Lieven, 2013/11/26
- Re: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb),
Paolo Bonzini <=
- [Qemu-devel] [PATCHv2 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 8/9] qemu-img: add option to show progress in sectors, Peter Lieven, 2013/11/26
- [Qemu-devel] [PATCHv2 1.8 7/9] qemu-img: round down request length to an aligned sector, Peter Lieven, 2013/11/26