Re: [Qemu-devel] [PATCH v3 05/19] block: handle ENOTSUP from discard in generic code

[Paolo Bonzini]

Il 25/11/2013 11:06, Peter Lieven ha scritto:
> wouldn't it make sense to return -ENOTSUP in other drivers a well if the
> operation is not supported and not return 0?

Yes; patches are welcome. :)

(I have a patch for block/iscsi.c that handles LBPU=1/LBPWS=0, and one
of the things it does is "return 0" -> "return -ENOTSUP" for consistency
between iscsi_co_discard and iscsi_co_write_zeroes).

Paolo