Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests

[Michael S. Tsirkin]

On Thu, Nov 21, 2013 at 10:40:43PM +0100, Erik Rull wrote:
> Marcel Apfelbaum wrote:
> >On Thu, 2013-11-21 at 22:20 +0100, Erik Rull wrote:
> >>Marcel Apfelbaum wrote:
> >>>Added 2 tests:
> >>>   1. Basic check of FACS table (missed on prev submission)
> >>>   2. Compare DSDT and SSDT tables against expected values
> >>>
> >>>Test 2:
> >>>   - runs only if iasl is installed on the host machine.
> >>>   - the test plan:
> >>>     1. Dumps the ACPI tables as AML on the disk.
> >>>     2. Runs iasl to disassembly the tables into ASL files.
> >>>     3. Compares them with expected offline ASL files.
> >>>
> >>>   - the test runs for both default machine and q35.
> >>>   - in case the test fails, it can be easily tweaked to
> >>>     show the differences between the ASL files and
> >>>     understand the issue.
> >>>
> >>>Patches:
> >>>   1/5 - test 1
> >>>   2/5 - some infrastructure improvements
> >>>   3/5 - expected asl files for test 2
> >>>   4/5 - creates links for the expected files
> >>>         if the build directory is not current
> >>>   5/5 - test 2
> >>>
> >>
> >>Which iasl Version is needed for the ACPI compilation and testing? I have
> >>an IASL installed on my build machine, but when trying to compile the ACPI
> >>stuff, it fails. Maybe it's just too old, but I didn't find a way to
> >>disable the iasl access. Must I uninstall iasl on my machine to get qemu
> >>compiled again?
> >I would use the latest version, version 20130823, from 
> >https://acpica.org/downloads
> >or the git from git://github.com/acpica/acpica.git
> >
> >I don't think you need iasl on your computer to build qemu.
> >
> >Hope I helped,
> >Marcel
> 
> Thanks.
> But then I don't understand the error that appears:
> 
>   CPP x86_64-softmmu/acpi-dsdt.dsl.i.orig
>   ACPI_PREPROCESS x86_64-softmmu/acpi-dsdt.dsl.i
>   IASL x86_64-softmmu/acpi-dsdt.dsl.i
> make[1]: *** [hw/i386/acpi-dsdt.hex] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2

It's because your IASL is present but appears broken.
I can't say what's broken just from the version you give -
building a source with matching version from debian gave me a working
iasl.

> I don't find a chance to disable this access/compilation within
> configure. If I just missed a possible option, it would be great to
> point me at it.

I responded to this on a separate thread.

> I found also when grep'ing through the sources that there is an "if"
> for check whether iasl is present or not. But setting --iasl=
> (empty) to force a removal of iasl for the qemu compilation gives a
> configure error.
> 
> Best regards,
> 
> Erik
> 

Yes, it's a configure bug. I sent a patch to fix this.

> 
> >
> >>The IASL version is:
> >>Intel ACPI Component Architecture
> >>ASL Optimizing Compiler version 20060912 [Dec 20 2006]
> >>Copyright (C) 2000 - 2006 Intel Corporation
> >>Supports ACPI Specification Revision 3.0a
> >>
> >>Thanks for your support.
> >>
> >>Best regards,
> >>
> >>Erik
> >>
> >>
> >>
> >
> >
> >
> 
> 
>