[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to
From: |
Christoffer Dall |
Subject: |
Re: [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code |
Date: |
Fri, 22 Nov 2013 09:52:43 -0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 22, 2013 at 05:17:11PM +0000, Peter Maydell wrote:
> Provide versions of the KVM PSCI constants to non-KVM code;
> this will allow us to avoid an ifdef in boards which set up
> a PSCI node in the device tree.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-arm/kvm-consts.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/target-arm/kvm-consts.h b/target-arm/kvm-consts.h
> index 6f56f72..4062f11 100644
> --- a/target-arm/kvm-consts.h
> +++ b/target-arm/kvm-consts.h
> @@ -36,6 +36,18 @@ MISMATCH_CHECK(CP_REG_SIZE_U32, KVM_REG_SIZE_U32)
> MISMATCH_CHECK(CP_REG_SIZE_U64, KVM_REG_SIZE_U64)
> MISMATCH_CHECK(CP_REG_ARM, KVM_REG_ARM)
>
> +#define PSCI_FN_BASE 0x95c1ba5e
> +#define PSCI_FN(n) (PSCI_FN_BASE + (n))
> +#define PSCI_FN_CPU_SUSPEND PSCI_FN(0)
> +#define PSCI_FN_CPU_OFF PSCI_FN(1)
> +#define PSCI_FN_CPU_ON PSCI_FN(2)
> +#define PSCI_FN_MIGRATE PSCI_FN(3)
> +
> +MISMATCH_CHECK(PSCI_FN_CPU_SUSPEND, KVM_PSCI_FN_CPU_SUSPEND)
> +MISMATCH_CHECK(PSCI_FN_CPU_OFF, KVM_PSCI_FN_CPU_OFF)
> +MISMATCH_CHECK(PSCI_FN_CPU_ON, KVM_PSCI_FN_CPU_ON)
> +MISMATCH_CHECK(PSCI_FN_MIGRATE, KVM_PSCI_FN_MIGRATE)
> +
> #undef MISMATCH_CHECK
>
> #endif
> --
> 1.7.9.5
>
These are the defines specifially chosen for the KVM implementation of
PSCI 0.1 right? I wonder if we should name them as such, but then it
conflicts with the actual KVM defines I guess. Also, perhaps unrelated,
I guess it makes sense to reuse this base and these function IDs if we
add PSCI support to QEMU itself for TCG. Hmmm.
-Christoffer
- [Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 02/11] device_tree.c: Terminate the empty reservemap in create_device_tree(), Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 09/11] target-arm: Don't hardcode KVM target CPU to be A15, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 03/11] hw/arm/boot: Allow boards to provide an fdt blob, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code, Peter Maydell, 2013/11/22
- Re: [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code,
Christoffer Dall <=
- [Qemu-devel] [PATCH v9 05/11] target-arm: Add ARMCPU field for Linux device-tree 'compatible' string, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 01/11] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 11/11] hw/arm/virt: Support -cpu host, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 08/11] linux-headers: Update from mainline, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 06/11] target-arm: Allow secondary KVM CPUs to be booted via PSCI, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform, Peter Maydell, 2013/11/22
- Re: [Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support, Christoffer Dall, 2013/11/22