[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cor
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane |
|
Date: |
Fri, 22 Nov 2013 15:43:55 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 22.11.2013 12:20, schrieb Paolo Bonzini:
> Il 22/11/2013 12:13, Peter Lieven ha scritto:
>>> I see where you come from, but I think the potential for this patch to
>>> break some working configuration (for some definition of working) is too
>>> high. Can you split out the fixes to the "fill in the blanks" logic?
>>
>> I can, but the number of sockets is logal to the parse function.
>
> Not sure why that matters, just make two patches instead of one.
...and please CC me and possibly Eduardo who refactored it last IIRC.
Andreas
>> What would you think is it okay to just send a warning about
>> the illegal config and drop the exit(1).
>
> Yes, that would be okay.
>
> Paolo
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg