[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/11] configure: Explicitly set ARFLAGS so we can bu
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 02/11] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0 |
Date: |
Thu, 21 Nov 2013 17:49:29 +0100 |
From: Peter Maydell <address@hidden>
Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be
explicitly specifying everything and not relying on any default
variables or rules. However we were accidentally relying on the
default ARFLAGS ("rv"). This went unnoticed because of a bug in
GNU Make 3.82 and earlier which meant that adding -rR to MAKEFLAGS
only affected submakes, not the currently running instance.
Explicitly set ARFLAGS in config-host.mak, in the same way we
handle CFLAGS and LDFLAGS; this will allow us to work with
Make 4.0.
Thanks to Paul Smith for analyzing this bug for us.
Cc: address@hidden
Reported-by: Ken Moffat <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
configure | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 508f6a5..ad12688 100755
--- a/configure
+++ b/configure
@@ -325,6 +325,9 @@ query_pkg_config() {
pkg_config=query_pkg_config
sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
+# If the user hasn't specified ARFLAGS, default to 'rv', just as make does.
+ARFLAGS="${ARFLAGS-rv}"
+
# default flags for all hosts
QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
@@ -3695,6 +3698,7 @@ echo "C compiler $cc"
echo "Host C compiler $host_cc"
echo "C++ compiler $cxx"
echo "Objective-C compiler $objcc"
+echo "ARFLAGS $ARFLAGS"
echo "CFLAGS $CFLAGS"
echo "QEMU_CFLAGS $QEMU_CFLAGS"
echo "LDFLAGS $LDFLAGS"
@@ -4276,6 +4280,7 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
echo "CXX=$cxx" >> $config_host_mak
echo "OBJCC=$objcc" >> $config_host_mak
echo "AR=$ar" >> $config_host_mak
+echo "ARFLAGS=$ARFLAGS" >> $config_host_mak
echo "AS=$as" >> $config_host_mak
echo "CPP=$cpp" >> $config_host_mak
echo "OBJCOPY=$objcopy" >> $config_host_mak
--
1.8.3.1
- [Qemu-devel] [PULL for-1.7 00/11] Miscellaneous -rc patches, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 01/11] sun4m: Add FCode ROM for TCX framebuffer, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 02/11] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0,
Paolo Bonzini <=
- [Qemu-devel] [PULL 04/11] atomic.h: Fix build with clang, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 06/11] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid(), Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 05/11] vfio-pci: Fix multifunction=on, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 08/11] rng-egd: offset the point when repeatedly read from the buffer, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 09/11] target-i386: yield to another VCPU on PAUSE, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 07/11] rng-egd: remove redundant free, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 10/11] mips jazz: do not raise data bus exception when accessing invalid addresses, Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 11/11] qga: Fix compiler warnings (missing format attribute, wrong format strings), Paolo Bonzini, 2013/11/21
- [Qemu-devel] [PULL 03/11] pc: get rid of builtin pvpanic for "-M pc-1.5", Paolo Bonzini, 2013/11/21
- Re: [Qemu-devel] [PULL for-1.7 00/11] Miscellaneous -rc patches, Paolo Bonzini, 2013/11/25