Re: [Qemu-devel] [PATCH 50/60] AArch64: Add "Floating-point<->fixed-point

[Janne Grunau]

On 2013-11-20 15:47:18 +0100, Michael Matz wrote:
> Hi,
> 
> On Tue, 19 Nov 2013, Janne Grunau wrote:
> 
> > > +static void handle_fpfpconv(DisasContext *s, uint32_t insn)
> > > +{
> > > +    int opcode = get_bits(insn, 16, 3);
> > > +    int rmode = get_bits(insn, 20, 2);
> > 
> > rmode is at 19
> > 
> > > +    case 0x1: /* [S|U]CVTF (scalar->float) */
> > 
> > and it's case 0x0: for [S|U]CVTF
> 
> Both were fixed after Alex' series with 0dd22d0c:
> https://github.com/susematz/qemu/commit/0dd22d0c5cd1dcdccd5df953f1981d461d3054e5

wouldn't make sense to squash that fix into this patch? I'm not used to
the qemu development model but committing patches with already fixed
issues looks strange to me. Unless it's planned to fold the entire patch
series into one large commit.

Janne