Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

[Michael S. Tsirkin]

On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote:
> it fixes IRQ storm since guest isn't able to lower SCI IRQ
> after it has been handled when it clears GPE event.
> 
> Signed-off-by: Igor Mammedov <address@hidden>

The storm is only on memory hotplug right?
But memory hotplug support is only added by next
patch.
Maybe just smash with that one?

> ---
>  hw/acpi/ich9.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index e59688b..fb88162 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -61,6 +61,7 @@ static void ich9_gpe_writeb(void *opaque, hwaddr addr, 
> uint64_t val,
>  {
>      ICH9LPCPMRegs *pm = opaque;
>      acpi_gpe_ioport_writeb(&pm->acpi_regs, addr, val);
> +    acpi_update_sci(&pm->acpi_regs, pm->irq, ACPI_MEMORY_HOTPLUG_STATUS);
>  }
>  
>  static const MemoryRegionOps ich9_gpe_ops = {
> -- 
> 1.7.1