Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

[Paolo Bonzini]

Il 19/11/2013 18:33, Andreas Färber ha scritto:
> Why? I still think that would be wrong. We had previously discussed with
> Paolo that VMState is global state, which according to Anthony should
> not be registered before realization. So far we have a mix of PCI host
> bridges instantiating PCIBus before or after realization depending on
> whether the bus name needs to depend on the device id or not (with trend
> towards instantiating the PCIBus during instance_init), at which point
> in time the state should not be registered yet. The sketched solution
> was to implement a "realized" property for BusState, so that we can
> decouple vmstate_register() from instantation time rather than moving it
> into instance_init.

I agree.  However, this is also a bug fix, and it would be a bit ugly to
tie it to large infrastructure changes (same reason why I want to have
my virtio hotplug/unplug fixes go in _before_ the realize patches, for
example).

With that in mind, Bandan's patch could be good for 1.7.

Paolo