qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL for-1.7 1/1] qom: Fix memory leak in object_property_


From: Andreas Färber
Subject: [Qemu-devel] [PULL for-1.7 1/1] qom: Fix memory leak in object_property_set_link()
Date: Tue, 19 Nov 2013 11:00:21 +0100

From: Vlad Yasevich <address@hidden>

Save the result of the call to object_get_canonical_path()
so we can free it.

Cc: address@hidden
Signed-off-by: Vlad Yasevich <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
 qom/object.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index b617f26..fc19cf6 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
 void object_property_set_link(Object *obj, Object *value,
                               const char *name, Error **errp)
 {
-    object_property_set_str(obj, object_get_canonical_path(value),
-                            name, errp);
+    gchar *path = object_get_canonical_path(value);
+    object_property_set_str(obj, path, name, errp);
+    g_free(path);
 }
 
 Object *object_property_get_link(Object *obj, const char *name,
-- 
1.8.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]