[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-1.7 06/13] tcg-ia64: Avoid unnecessary stop bit i
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL for-1.7 06/13] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu |
Date: |
Tue, 19 Nov 2013 07:49:48 +1000 |
When performing an operation with two input registers, we'd leave
the stop bit (and thus an extra cycle) that's only needed when one
or the other input is a constant.
Acked-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/ia64/tcg-target.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 11a414c..aeb6bc7 100644
--- a/tcg/ia64/tcg-target.c
+++ b/tcg/ia64/tcg-target.c
@@ -1044,31 +1044,26 @@ static inline void tcg_out_st(TCGContext *s, TCGType
type, TCGReg arg,
}
}
-static inline void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGArg ret,
- TCGArg arg1, int const_arg1,
- TCGArg arg2, int const_arg2)
+static void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGReg ret, TCGArg
arg1,
+ int const_arg1, TCGArg arg2, int const_arg2)
{
- uint64_t opc1, opc2;
+ uint64_t opc1 = 0, opc2 = 0;
if (const_arg1 && arg1 != 0) {
opc1 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5,
TCG_REG_R2, arg1, TCG_REG_R0);
arg1 = TCG_REG_R2;
- } else {
- opc1 = INSN_NOP_M;
}
if (const_arg2 && arg2 != 0) {
opc2 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5,
TCG_REG_R3, arg2, TCG_REG_R0);
arg2 = TCG_REG_R3;
- } else {
- opc2 = INSN_NOP_I;
}
- tcg_out_bundle(s, mII,
- opc1,
- opc2,
+ tcg_out_bundle(s, (opc1 || opc2 ? mII : miI),
+ opc1 ? opc1 : INSN_NOP_M,
+ opc2 ? opc2 : INSN_NOP_I,
tcg_opc_a1(TCG_REG_P0, opc_a1, ret, arg1, arg2));
}
--
1.8.3.1
- [Qemu-devel] [PULL for-1.7 00/13] tcg-ia64 improvements, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 01/13] tcg-ia64: Use TCGMemOp within qemu_ldst routines, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 02/13] tcg-ia64: Use shortcuts for nop insns, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 03/13] tcg-ia64: Handle constant calls, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 04/13] tcg-ia64: Simplify brcond, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 05/13] tcg-ia64: Move AREG0 to R32, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 06/13] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu,
Richard Henderson <=
- [Qemu-devel] [PULL for-1.7 07/13] tcg-ia64: Use ADDS for small addition, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 08/13] tcg-ia64: Use SUB_A3 and ADDS_A4 for subtraction, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 09/13] tcg-ia64: Use A3 form of logical operations, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 10/13] tcg-ia64: Introduce tcg_opc_mov_a, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 11/13] tcg-ia64: Introduce tcg_opc_movi_a, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 12/13] tcg-ia64: Introduce tcg_opc_ext_i, Richard Henderson, 2013/11/18
- [Qemu-devel] [PULL for-1.7 13/13] tcg-ia64: Introduce tcg_opc_bswap64_i, Richard Henderson, 2013/11/18