qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
Date: Thu, 14 Nov 2013 12:17:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9

Il 14/11/2013 12:06, Peter Maydell ha scritto:
> On 14 November 2013 05:40, Stefan Weil <address@hidden> wrote:
>> If you happen to write a v3 patch, g_assert_not_reached would be even
>> better than abort.
>>
>> It's impossible to tell why QEMU terminated after an assert without a
>> debugger,
>> whereas g_assert_not_reached clearly shows the location.
> 
> Maybe. I was mostly just following the pattern of existing
> stub functions. Should all instances of abort() be replaced?
> (g_assert_not_reached() is compile-time disablable, unlike
> abort()).

No, disabling asserts is almost always bad, but disabling unconditional
asserts is even worse.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]