Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

[Michael S. Tsirkin]

On Tue, Nov 12, 2013 at 11:08:07AM -0600, Corey Minyard wrote:
> On 11/12/2013 10:43 AM, Eric Blake wrote:
> > On 11/12/2013 09:33 AM, Corey Minyard wrote:
> >> Allow a socket that connects to reconnect on a periodic basis if it
> >> fails to connect at startup or if the connection drops while in use.
> >>
> >> Signed-off-by: Corey Minyard <address@hidden>
> >> ---
> >>  include/sysemu/char.h |  3 ++
> >>  qemu-char.c           | 88 
> >> ++++++++++++++++++++++++++++++++++++++++++++-------
> >>  qemu-options.hx       | 11 +++++--
> >>  3 files changed, 87 insertions(+), 15 deletions(-)
> >>
> >> +++ b/qemu-options.hx
> >> @@ -1780,8 +1780,9 @@ ETEXI
> >>  DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
> >>      "-chardev null,id=id[,mux=on|off]\n"
> >>      "-chardev 
> >> socket,id=id[,host=host],port=host[,to=to][,ipv4][,ipv6][,nodelay]\n"
> >> -    "         [,server][,nowait][,telnet][,mux=on|off] (tcp)\n"
> >> -    "-chardev 
> >> socket,id=id,path=path[,server][,nowait][,telnet],[mux=on|off] (unix)\n"
> >> +    "         
> >> [,server][,nowait][,telnet][,mux=on|off][,reconnect=seconds] (tcp)\n"
> >> +    "-chardev 
> >> socket,id=id,path=path[,server][,nowait][,telnet][,mux=on|off]\n"
> >> +    "         [,reconnect=seconds] (unix)\n"
> >> address@hidden specifies that if the socket does not come up at startup,
> >> +or if the socket is closed for some reason (like the other end exited),
> >> +wait the given number of seconds and attempt to reconnect.
> > Sounds cool.  Are you planning on also adding the QMP counterpart for
> > specifying this option when doing hotplugs of a chardev? 
> 
> Yes, I need to add that.
> 
> >  Does reconnect
> > make any sense when not using server mode?
> >
> Actually, it only really makes sense when in client mode.  The option
> currently won't do anything in server mode.  I can't see a use for it in
> server mode, it doesn't know where to connect.
> 
> -corey

I guess it could mean "allow reconnect from a client"?