[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_syste
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1() |
Date: |
Fri, 8 Nov 2013 15:16:42 +0000 |
On 8 November 2013 15:07, Laszlo Ersek <address@hidden> wrote:
> On 11/08/13 07:09, Jordan Justen wrote:
>> int64_t? :)
>
> Heh, yes, I did cringe when I wrote that, but if you check the
> bottom-most function, where the assignment happens,
> pc_system_flash_init(), it declares the local "size" variable as
> int64_t. I've given up on arguing for sensible unsigned types so I just
> went with the flow
That's a bug in that function which should be fixed.
This is a memory region size and those are uint64_t.
That said, having to pass the size of a sub-sub-region
all the way back up the call stack is very odd and makes
me wonder if it's really the right way to do it...
The top level shouldn't have to care like that about
details of the bottom of the callstack.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size, (continued)
- Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size, Laszlo Ersek, 2013/11/07
- Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size, Marcel Apfelbaum, 2013/11/07
- [Qemu-devel] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size, Laszlo Ersek, 2013/11/07
- [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1(), Laszlo Ersek, 2013/11/07
- Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1(), Jordan Justen, 2013/11/08
- Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1(), Laszlo Ersek, 2013/11/08
- Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1(),
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1(), Laszlo Ersek, 2013/11/08
- Re: [Qemu-devel] [PATCH 1/2] i386/pc: propagate flash size from pc_system_flash_init() to pc_init1(), Peter Maydell, 2013/11/08
- [Qemu-devel] [PATCH 2/2] i386/pc_piix: the pci-hole should end where the system flash starts, Laszlo Ersek, 2013/11/07
- [Qemu-devel] reverting commit a53ae8e934cd54686875b5bcfc2f434244ee55d6 Re: [edk2] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size, Paolo Bonzini, 2013/11/08
- Re: [Qemu-devel] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size, Igor Mammedov, 2013/11/08
Re: [Qemu-devel] [PATCH] exec: fix regression by making system-memory region UINT64_MAX size, Andreas Färber, 2013/11/08