Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

[Anthony Liguori]

On Wed, Nov 6, 2013 at 3:15 AM, Gerd Hoffmann <address@hidden> wrote:
> On Mi, 2013-11-06 at 10:48 +0000, Peter Maydell wrote:
>
>> > That is clearly 1.8 material though.  I think for 1.7 we should simply
>> > leave things as-is.
>>
>> Do you mean "as-is with Anthony's patch applied", or "as it was
>> before that patch was applied" ?
>
> Oh, it is in?
>
>>  I would suggest the latter
>> (ie revert this patch), because that's the safest choice this
>> close to release.
>
> Agree.

I don't think you guys understand what is happening.

As ossaudio is able to be default, it *will be selected* as the audio
output backend unconditionally.  You aren't seeing errors during
probing, you're seeing errors post-initialization.

The ossaudio init function is simply:

static void *oss_audio_init (void)
{
    return &conf;
}

It never fails.  So audio is broken on Linux by default today.  This
patch unbreaks it.  If you compare this to the pulseaudio backend
where init can actually fail, you can see why it can be default but
ossaudio really can't.

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>