qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 09/10] tests: fix memleak in error path test


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH RFC 09/10] tests: fix memleak in error path test for input visitor
Date: Wed, 06 Nov 2013 10:18:10 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1

于 2013/11/5 21:20, Eric Blake 写道:
On 11/04/2013 05:37 PM, Wenchao Xia wrote:
Signed-off-by: Wenchao Xia <address@hidden>
Cc: address@hidden
---
  tests/test-qmp-input-visitor.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

You should repost your mem-leak patches for qemu-stable as an
independent thread marked "for-1.7", without RFC, to ensure that they
are applied in a timely manner without waiting for the rest of this series.


  OK, will resend.


diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visitor.c
index 0beb8fb..1e1c6fa 100644
--- a/tests/test-qmp-input-visitor.c
+++ b/tests/test-qmp-input-visitor.c
@@ -604,6 +604,7 @@ static void test_visitor_in_errors(TestInputVisitorData 
*data,
      g_assert(error_is_set(&errp));
      g_assert(p->string == NULL);

+    error_free(errp);
      g_free(p->string);
      g_free(p);
  }






reply via email to

[Prev in Thread] Current Thread [Next in Thread]