[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.7] vga: fix invalid read after free
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.7] vga: fix invalid read after free |
|
Date: |
Tue, 05 Nov 2013 16:25:50 +0100 |
On Di, 2013-11-05 at 16:15 +0100, Marc-André Lureau wrote:
> --- a/hw/display/vga.c
> +++ b/hw/display/vga.c
> @@ -1707,7 +1707,6 @@ static void vga_draw_graphic(VGACommonState *s,
> int full_update)
> } else if (is_buffer_shared(surface) &&
> (full_update || surface_data(surface) != s->vram_ptr
> + (s->start_addr * 4))) {
> - DisplaySurface *surface;
> surface = qemu_create_displaysurface_from(disp_width,
> height, depth, s->line_offset,
> s->vram_ptr + (s->start_addr * 4), byteswap);
Reviewed-by: Gerd Hoffmann <address@hidden>
cheers,
Gerd