[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails |
|
Date: |
Tue, 05 Nov 2013 04:50:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote:
> qdev_device_add() leaks the created qdev upon failure. I suspect this
> problem crept in because qdev_free() unparents the qdev but does not
> drop a reference - confusing name.
Is it worth renaming in a future patch?
>
> Also drop trailing whitespace after curly bracket.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qdev-monitor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails,
Eric Blake <=