Re: [Qemu-devel] [PATCH v2 0/2] block/drive-mirror: Check for NULL backing_hd

[Paolo Bonzini]

Il 05/11/2013 01:35, Max Reitz ha scritto:
> It should be possible to execute the QMP "drive-mirror" command in
> "none" sync mode and "absolute-paths" mode even for block devices
> lacking a backing file.
> 
> "absolute-paths" does in fact not require a backing file to be present,
> as can be seen from the "top" sync mode code path. "top" basically
> states that the device should indeed have a backing file - however, the
> current code catches the case if it doesn't and then simply treats it as
> "full" sync mode, creating a target image without a backing file (in
> "absolute-paths" mode). Thus, "absolute-paths" does not imply the target
> file must indeed have a backing file.
> 
> Therefore, the target file may be left unbacked in case of "none" sync
> mode as well, if the specified device is not backed either. Currently,
> qemu will crash trying to dereference the backing file pointer since it
> assumes that it will always be non-NULL in that case ("none" with
> "absolute-paths").
> 
> The first patch in this series adds a check whether the specified block
> device is backed or not (creating an unbacked target image, if required);
> the second patch adds a test case for mirroring unbacked block devices.
> 
> 
> Max Reitz (2):
>   block/drive-mirror: Check for NULL backing_hd
>   qemu-iotests: Add test for unbacked mirroring
> 
>  blockdev.c                 |  4 +-
>  tests/qemu-iotests/070     | 91 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/070.out | 33 +++++++++++++++++
>  tests/qemu-iotests/group   |  1 +
>  4 files changed, 127 insertions(+), 2 deletions(-)
>  create mode 100755 tests/qemu-iotests/070
>  create mode 100644 tests/qemu-iotests/070.out
> 

Patch 1 is fine.

For patch 2, there are existing drive-mirror tests written in Python.
I'll let the maintainers whether they are fine with a new test, or
prefer to extend those with a new testcase.

Paolo