Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product & version by default

[Markus Armbruster]

"Michael S. Tsirkin" <address@hidden> writes:

> On Wed, Oct 30, 2013 at 01:56:40PM +0100, address@hidden wrote:
>> From: Markus Armbruster <address@hidden>
>> 
>> Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs,
>> no version.  Best SeaBIOS can do, but we can provide better defaults:
>> manufacturer QEMU, product & version taken from QEMUMachine desc and
>> name.
>> 
>> Take care to do this only for new machine types, of course.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> I feel applying this one would be a mistake.
>
> Machine desc is for human readers.
> For example, it currently says "Standard PC (Q35 + ICH9, 2009)"
> but if we add a variant with IDE compatibility mode we will likely want to
> tweak it to say "Standard PC (Q35 + ICH9/AHCI mode, 2009)"
> and add another one saying ""Standard PC (Q35 + ICH9/compat mode,
> 2009)".
>
> In other words we want the ability to tweak
> description retroactively, and exposing it to guest will
> break this ability.
>
> So we really need a new field not tied to the human description.

Can you live with the separation I just posted as PATCH 3/2?