Re: [Qemu-devel] [PATCHv6 11/17] iscsi: set limits in BlockDriverState

[Paolo Bonzini]

Il 24/10/2013 08:46, Peter Lieven ha scritto:
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  block/iscsi.c |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 47b9cc9..c0465aa 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1367,6 +1367,20 @@ static int iscsi_open(BlockDriverState *bs, QDict 
> *options, int flags,
>                 sizeof(struct scsi_inquiry_block_limits));
>          scsi_free_scsi_task(task);
>          task = NULL;
> +
> +        if (iscsilun->bl.max_unmap < 0xffffffff) {
> +            bs->bl.max_discard = sector_lun2qemu(iscsilun->bl.max_unmap,
> +                                                 iscsilun);
> +        }
> +        bs->bl.discard_alignment = 
> sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
> +                                                   iscsilun);
> +
> +        if (iscsilun->bl.max_ws_len < 0xffffffff) {
> +            bs->bl.max_write_zeroes = 
> sector_lun2qemu(iscsilun->bl.max_ws_len,
> +                                                      iscsilun);
> +        }
> +        bs->bl.write_zeroes_alignment = 
> sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
> +                                                        iscsilun);
>      }
>  
>  #if defined(LIBISCSI_FEATURE_NOP_COUNTER)
> 

This patch and the previous one needs to be swapped, but maintainers can
do that.

Paolo